Print this page
6601 Various GLD drivers return EINVAL instead of ENOTSUP for unused mac_prop_id_t's
Reviewed by: Garrett D'Amore <garrett@damore.org>
Reviewed by: Dan McDonald <danmcd@omniti.com>
Reviewed by: Igor Kozhukhov <ikozhukhov@gmail.com>

Split Close
Expand all
Collapse all
          --- old/usr/src/uts/common/io/ixgbe/ixgbe_gld.c
          +++ new/usr/src/uts/common/io/ixgbe/ixgbe_gld.c
↓ open down ↓ 18 lines elided ↑ open up ↑
  19   19   * CDDL HEADER END
  20   20   */
  21   21  
  22   22  /*
  23   23   * Copyright(c) 2007-2010 Intel Corporation. All rights reserved.
  24   24   */
  25   25  
  26   26  /*
  27   27   * Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved.
  28   28   * Copyright 2012 Nexenta Systems, Inc. All rights reserved.
       29 + * Copyright 2016 OmniTI Computer Consulting, Inc. All rights reserved.
  29   30   */
  30   31  
  31   32  #include "ixgbe_sw.h"
  32   33  
  33   34  /*
  34   35   * Bring the device out of the reset/quiesced state that it
  35   36   * was in when the interface was registered.
  36   37   */
  37   38  int
  38   39  ixgbe_m_start(void *arg)
↓ open down ↓ 385 lines elided ↑ open up ↑
 424  425                           */
 425  426                          tx_size = ixgbe->max_frame_size;
 426  427                          ixgbe->tx_buf_size = ((tx_size >> 10) + ((tx_size &
 427  428                              (((uint32_t)1 << 10) - 1)) > 0 ? 1 : 0)) << 10;
 428  429                  }
 429  430                  break;
 430  431          case MAC_PROP_PRIVATE:
 431  432                  err = ixgbe_set_priv_prop(ixgbe, pr_name, pr_valsize, pr_val);
 432  433                  break;
 433  434          default:
 434      -                err = EINVAL;
      435 +                err = ENOTSUP;
 435  436                  break;
 436  437          }
 437  438          mutex_exit(&ixgbe->gen_lock);
 438  439          return (err);
 439  440  }
 440  441  
 441  442  int
 442  443  ixgbe_m_getprop(void *arg, const char *pr_name, mac_prop_id_t pr_num,
 443  444      uint_t pr_valsize, void *pr_val)
 444  445  {
↓ open down ↓ 52 lines elided ↑ open up ↑
 497  498                  *(uint8_t *)pr_val = ixgbe->param_adv_100fdx_cap;
 498  499                  break;
 499  500          case MAC_PROP_EN_100FDX_CAP:
 500  501                  *(uint8_t *)pr_val = ixgbe->param_en_100fdx_cap;
 501  502                  break;
 502  503          case MAC_PROP_PRIVATE:
 503  504                  err = ixgbe_get_priv_prop(ixgbe, pr_name,
 504  505                      pr_valsize, pr_val);
 505  506                  break;
 506  507          default:
 507      -                err = EINVAL;
      508 +                err = ENOTSUP;
 508  509                  break;
 509  510          }
 510  511          return (err);
 511  512  }
 512  513  
 513  514  void
 514  515  ixgbe_m_propinfo(void *arg, const char *pr_name, mac_prop_id_t pr_num,
 515  516      mac_prop_info_handle_t prh)
 516  517  {
 517  518          ixgbe_t *ixgbe = (ixgbe_t *)arg;
↓ open down ↓ 278 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX